[jira] [Commented] (AMBARI-14501) Improve config recommendations flow 2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-14501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072648#comment-15072648 ] 

Hadoop QA commented on AMBARI-14501:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12779636/AMBARI-14501.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-web.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/4720//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/4720//console

This message is automatically generated.

> Improve config recommendations flow 2
> -------------------------------------
>
>                 Key: AMBARI-14501
>                 URL: https://issues.apache.org/jira/browse/AMBARI-14501
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-web
>    Affects Versions: 2.4.0
>            Reporter: Andrii Babiichuk
>            Assignee: Andrii Babiichuk
>             Fix For: 2.4.0
>
>         Attachments: AMBARI-14501.patch
>
>
> Simplify logic to make it reusable (ex. for Kerberos) and performance improvement.
> Separete logic for original configs and overrides, move it do diff mixins
> Separate logic for recommendatins popup manipulations.
> Move specific logic like override initial value or ignore recommendations (ex Add service installed services) to appropriate controllers.
> Besides logical refactor this cahges decrease recommendation flow process for 0.2-0.4 secs for full stack



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)