You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars George (JIRA)" <ji...@apache.org> on 2010/11/24 11:58:13 UTC
[jira] Created: (HBASE-3274) Replace all config properties
references in code with string constants
Replace all config properties references in code with string constants
----------------------------------------------------------------------
Key: HBASE-3274
URL: https://issues.apache.org/jira/browse/HBASE-3274
Project: HBase
Issue Type: Improvement
Reporter: Lars George
Priority: Trivial
See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Work logged] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Work logged) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel\#worklog-{worklog.getId()} ]
Harsh J logged work on HBASE-3274:
----------------------------------
Author: Harsh J
Created on: 28/Dec/11 04:15
Start Date: 28/Dec/11 04:15
Worklog Time Spent: 2h
Issue Time Tracking
-------------------
Worklog Id: (was: 12535)
Time Spent: 2h
Remaining Estimate: 166h (was: 168h)
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Time Spent: 2h
> Remaining Estimate: 166h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176276#comment-13176276 ]
Lars Hofhansl commented on HBASE-3274:
--------------------------------------
Big +1.
I have actually reviewed some recent patches that add config names as string. Sorry I did not point that out as defect.
Also many people turn to hbase-default.xml, but many (new and old) configs are not in there.
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-3274:
-------------------------------
Attachment: HBASE-3274.D1053.1.patch
QwertyManiac requested code review of "HBASE-3274 [jira] Replace all config properties references in code with string constants".
Reviewers: JIRA
Fixes for source packages avro to io.
See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D1053
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/HConstants.java
src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
src/main/java/org/apache/hadoop/hbase/client/HTable.java
src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/2199/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Attachments: HBASE-3274.D1053.1.patch
>
> Original Estimate: 168h
> Time Spent: 2h
> Remaining Estimate: 166h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated HBASE-3274:
---------------------------
Remaining Estimate: 168h
Original Estimate: 168h
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Work started) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HBASE-3274 started by Harsh J.
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176204#comment-13176204 ]
Harsh J commented on HBASE-3274:
--------------------------------
I'm recording all the strange param names I encounter as I do this at https://gist.github.com/76416a2211ece8edb95a
Meanwhile, am hoping no more patches get in with config names as strings… :)
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J reassigned HBASE-3274:
------------------------------
Assignee: Harsh J
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3274) Replace all config properties
references in code with string constants
Posted by "Harsh J (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176721#comment-13176721 ]
Harsh J commented on HBASE-3274:
--------------------------------
So I posted a diff manually at https://reviews.facebook.net/D1047 for review to take off incrementally, but can't seem to link it to the hbase project. Is using arc the only option?
> Replace all config properties references in code with string constants
> ----------------------------------------------------------------------
>
> Key: HBASE-3274
> URL: https://issues.apache.org/jira/browse/HBASE-3274
> Project: HBase
> Issue Type: Improvement
> Reporter: Lars George
> Assignee: Harsh J
> Priority: Trivial
> Original Estimate: 168h
> Time Spent: 2h
> Remaining Estimate: 166h
>
> See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira