[GitHub] [ignite] AMashenkov commented on a change in pull request #9046: IGNITE-12991: Calcite integration. Query Cancellation

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #9046:
URL: https://github.com/apache/ignite/pull/9046#discussion_r735601034



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionContext.java
##########
@@ -277,16 +295,26 @@ public void execute(RunnableX task, Consumer<Throwable> onError) {
     }
 
     /**
-     * Sets cancel flag, returns {@code true} if flag was changed by this call.
+     * Sets finish flag, returns {@code true} if flag was changed by this call.
      *
      * @return {@code True} if flag was changed by this call.
      */
-    public boolean cancel() {
-        return !cancelFlag.get() && cancelFlag.compareAndSet(false, true);
+    public boolean finish() {
+        boolean finishedRightNow = !finishFlag.get() && finishFlag.compareAndSet(false, true);

Review comment:
       ```suggestion
           boolean finishedRightNow = finishFlag.compareAndSet(false, true);
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org