[GitHub] [lucene-solr] uschindler commented on a change in pull request #1732: Clean up many small fixes

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #1732:
URL: https://github.com/apache/lucene-solr/pull/1732#discussion_r468374779



##########
File path: lucene/core/src/java/org/apache/lucene/analysis/Analyzer.java
##########
@@ -367,12 +367,12 @@ public void close() {
     /**
      * Original source of the tokens.
      */
-    protected final Consumer<Reader> source;

Review comment:
       Removing this would break many outside analyzers. I know it's seldom that analyzers access these fields, but this is a real backward breaking change. Don't do this.
   
   I have no problem with the ctors, but here it's serious! Why did Intellij suggest a change like that? Looks like it was not so intelligent. 🤨




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org