You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/22 07:36:21 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #11385: fix: bump superset-ui/core (P0 filters branch)
villebro opened a new pull request #11385:
URL: https://github.com/apache/incubator-superset/pull/11385
### SUMMARY
The new version of `superset-ui/core` hadn't been released at the time of the previous PR, hence this bump was missing. This is required to make new charts work with new filter indicator.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
Local testing.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #11385: fix: bump superset-ui/core (P0 filters branch)
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #11385:
URL: https://github.com/apache/incubator-superset/pull/11385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11385: fix: bump superset-ui/core (P0 filters branch)
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11385:
URL: https://github.com/apache/incubator-superset/pull/11385#issuecomment-714314991
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=h1) Report
> Merging [#11385](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=desc) into [feature/filter-p0](https://codecov.io/gh/apache/incubator-superset/commit/66d16995a6d116f6f4a4128ed3396f68af9ff7bc?el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## feature/filter-p0 #11385 +/- ##
=====================================================
- Coverage 65.89% 65.60% -0.29%
=====================================================
Files 832 831 -1
Lines 40326 39647 -679
Branches 3710 3614 -96
=====================================================
- Hits 26571 26009 -562
+ Misses 13644 13527 -117
Partials 111 111
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.94% <ø> (-0.02%)` | :arrow_down: |
| #javascript | `62.42% <ø> (-0.17%)` | :arrow_down: |
| #python | `60.83% <ø> (-0.50%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `59.22% <0.00%> (-10.16%)` | :arrow_down: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | `55.81% <0.00%> (-8.57%)` | :arrow_down: |
| [...rset-frontend/src/SqlLab/components/QueryTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5VGFibGUuanN4) | `62.79% <0.00%> (-7.73%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `89.36% <0.00%> (-4.61%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `64.52% <0.00%> (-1.07%)` | :arrow_down: |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | `87.44% <0.00%> (-1.00%)` | :arrow_down: |
| [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | `68.88% <0.00%> (-0.13%)` | :arrow_down: |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `90.47% <0.00%> (ø)` | |
| [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=) | `100.00% <0.00%> (ø)` | |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/11385/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=footer). Last update [66d1699...234e0a1](https://codecov.io/gh/apache/incubator-superset/pull/11385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org