You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2017/02/27 12:49:08 UTC
[05/50] [abbrv] tinkerpop git commit: Improved code comments
regarding authorization after Kerberos authentication
Improved code comments regarding authorization after Kerberos authentication
Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/a5f3e1fb
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/a5f3e1fb
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/a5f3e1fb
Branch: refs/heads/TINKERPOP-1612
Commit: a5f3e1fb14afc691a8cb9617d8da4417c514aeaa
Parents: 6a9c667
Author: HadoopMarc <vt...@xs4all.nl>
Authored: Sat Jan 14 20:19:23 2017 +0100
Committer: HadoopMarc <vt...@xs4all.nl>
Committed: Wed Jan 18 20:08:00 2017 +0100
----------------------------------------------------------------------
.../tinkerpop/gremlin/server/auth/Krb5Authenticator.java | 5 +++++
.../server/GremlinServerAuthKrb5IntegrateTest.java | 10 +---------
2 files changed, 6 insertions(+), 9 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/a5f3e1fb/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/Krb5Authenticator.java
----------------------------------------------------------------------
diff --git a/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/Krb5Authenticator.java b/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/Krb5Authenticator.java
index 275dba6..9733523 100644
--- a/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/Krb5Authenticator.java
+++ b/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/auth/Krb5Authenticator.java
@@ -37,6 +37,7 @@ import java.util.Map;
/**
* A Kerberos (GSSAPI) implementation of an {@link Authenticator}
+ * This authenticator authenticates and autorizes all clients with a valid service ticket.
*
* @author Marc de Lignie
*/
@@ -137,6 +138,10 @@ public class Krb5Authenticator implements Authenticator {
/*
* This method is based on the handle() method from:
* https://github.com/apache/directory-kerby/blob/kerby-all-1.0.0-RC2/kerby-kerb/integration-test/src/main/java/org/apache/kerby/kerberos/kerb/integration/test/sasl/SaslAppServer.java
+ *
+ * This provides the simplest form of authorization, where each client that provides a valid service ticket,
+ * is authorized. More elaborate authorization schemes would interrogate a policy server like Apache Ranger
+ * or ACL's of a storage backend.
*/
@Override
public void handle(Callback[] callbacks) throws UnsupportedCallbackException {
http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/a5f3e1fb/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
----------------------------------------------------------------------
diff --git a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
index 9573208..22d38cd 100644
--- a/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
+++ b/gremlin-server/src/test/java/org/apache/tinkerpop/gremlin/server/GremlinServerAuthKrb5IntegrateTest.java
@@ -205,15 +205,7 @@ public class GremlinServerAuthKrb5IntegrateTest extends AbstractGremlinServerInt
}
}
-// ToDo: Unclear how to test this
-// @Test
-// public void shouldFailWithAuthIdUnequalAuthzId() throws Exception {
-// server = new GremlinServerAuthKrb5Integrate(getServerPrincipal(), serviceKeytabFile);
-// server.setUp();
-// }
-
-
- // This test backs a fix in gremlin-driver (cd628b251f6956c826df20c89177680fe120ff99)
+ // This test backs a fix in gremlin-driver (see commit cd628b251f6956c826df20c89177680fe120ff99)
// Maybe gremlin-driver needs its own test with client.submit("[1,2,3] as byte[]")
@Test
public void shouldAuthenticateWithSerializeResultToString() throws Exception {