You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Xuefu Zhang <xz...@cloudera.com> on 2013/10/27 05:49:59 UTC

Review Request 14977: HIVE-5656: Hive produces unclear, confusing SemanticException when dealing with mod or pmod by zero

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14977/
-----------------------------------------------------------

Review request for hive and Brock Noland.


Bugs: HIVE-5656
    https://issues.apache.org/jira/browse/HIVE-5656


Repository: hive-git


Description
-------

Fix the problem so that NULL is produced.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 8653082 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java dc6a862 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java PRE-CREATION 
  ql/src/test/results/clientpositive/vectorization_14.q.out f00c1ea 

Diff: https://reviews.apache.org/r/14977/diff/


Testing
-------

Manually tested and the seen error msg is gone. Added new testcase. Had to generate .out for an old test case.


Thanks,

Xuefu Zhang