You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/17 12:53:00 UTC

[GitHub] [druid] AshishKapoor opened a new issue #10402: Make use of a single instance of Axios in the web-console

AshishKapoor opened a new issue #10402:
URL: https://github.com/apache/druid/issues/10402


   ### Motivation
   Make use of a single instance of Axios in the web-console.
   
   ### Proposed changes
   This will lead to changes in all the API calls made using Axios's multiple instances to a single instance.
   
   This section should include any changes made to user-facing interfaces, for example:
   - API network calls only
   
   ### Rationale
   - This can lead to added benefits of the Axios library where anyone can add or remove network-based configurations.
   - Can help in the separation of all network requests from the views.
   - Removal of multiple instances of Axios which will reduce the import size.
   
   ### Operational impact
   This section should describe how the proposed changes will impact the operation of existing clusters. It should answer questions such as:
   
   - Is anything going to be deprecated or removed by this change? How will we phase out old behavior?
   No, we will be only phasing out the multiple instances of Axios which will reduce the import size.
   
   - Is there a migration path that cluster operators need to be aware of?
   No
   
   - Will there be any effect on the ability to do a rolling upgrade, or to do a rolling _downgrade_ if an operator wants to switch back to a previous version?
   No
   
   ### Test plan
   An optional discussion of how the proposed changes will be tested. This section should focus on the higher-level system test strategy and not unit tests (as UTs will be implementation-dependent). 
   Not applicable should pass all the existing unit tests.
   
   ### Future work
   We can separate all the network requests out of the views and keep them under the respective names.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] AshishKapoor commented on issue #10402: Make use of a single instance of Axios in the web-console

Posted by GitBox <gi...@apache.org>.
AshishKapoor commented on issue #10402:
URL: https://github.com/apache/druid/issues/10402#issuecomment-694239890


   Hi! @vogievetsky
   
   Please take a look.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] clintropolis closed issue #10402: Make use of a single instance of Axios in the web-console

Posted by GitBox <gi...@apache.org>.
clintropolis closed issue #10402:
URL: https://github.com/apache/druid/issues/10402


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org