You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2019/02/27 17:46:00 UTC

[jira] [Comment Edited] (SOLR-7321) Remove reflection in FSHDFSUtils.java

    [ https://issues.apache.org/jira/browse/SOLR-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779571#comment-16779571 ] 

Kevin Risden edited comment on SOLR-7321 at 2/27/19 5:45 PM:
-------------------------------------------------------------

BasicAuthIntegrationTest.testBasicAuth failed and fails periodically on master without this patch. For reference here is the reproduce with line:
{code:java}
ant test  -Dtestcase=BasicAuthIntegrationTest -Dtests.method=testBasicAuth -Dtests.seed=B295B060F9E64CE6 -Dtests.multiplier=2 -Dtests.slow=true -Dtests.locale=da -Dtests.timezone=America/Asuncion -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
{code}
No tests added since there were no tests previously for this. Checked that FSHDFSUtils still matches closely to the HBase FSHDFSUtils version that this was originally copied from. 


was (Author: risdenk):
BasicAuthIntegrationTest.testBasicAuth failed and fails periodically. For reference here is the reproduce with line:
{code:java}
ant test  -Dtestcase=BasicAuthIntegrationTest -Dtests.method=testBasicAuth -Dtests.seed=B295B060F9E64CE6 -Dtests.multiplier=2 -Dtests.slow=true -Dtests.locale=da -Dtests.timezone=America/Asuncion -Dtests.asserts=true -Dtests.file.encoding=ISO-8859-1
{code}
No tests added since there were no tests previously for this. Checked that FSHDFSUtils still matches closely to the HBase FSHDFSUtils version that this was originally copied from. 

> Remove reflection in FSHDFSUtils.java
> -------------------------------------
>
>                 Key: SOLR-7321
>                 URL: https://issues.apache.org/jira/browse/SOLR-7321
>             Project: Solr
>          Issue Type: Improvement
>          Components: Hadoop Integration, SolrCloud
>            Reporter: Mike Drob
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 8.x, master (9.0)
>
>         Attachments: SOLR-7321.patch, SOLR-7321.patch
>
>
> When we copied FSHDFSUtil from HBase in SOLR-6969 we also carried over their compatability shims for both Hadoop 1 and Hadoop 2. Since we only support Hadoop 2, we don't need to do reflection in this class and can just invoke the methods directly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org