You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by ZhangJian He <sh...@gmail.com> on 2021/12/15 05:38:39 UTC
CheckStyle Rule Change
Hello everyone, I have added checkstyle on pulsar-metadata, and
UnusedImports check on test code. If your PR is involved in these two
situations. Please pull the master code. Thanks
Thanks
ZhangJian He
Re: CheckStyle Rule Change
Posted by Ivan Kelly <iv...@apache.org>.
Ignore this, looked further and it actually does double resolution. sheesh
On Wed, Dec 15, 2021 at 10:14 AM Ivan Kelly <iv...@apache.org> wrote:
>
> Maybe this has been discussed elsewhere, but if possible, we should
> add a rule that to block any future log4shell type attack area.
> In human terms, the rule should be:
> Disallow any {log,logger,LOG}.* with a non-const first argument.
>
> -Ivan
>
> On Wed, Dec 15, 2021 at 7:15 AM Enrico Olivelli <eo...@gmail.com> wrote:
> >
> > Il Mer 15 Dic 2021, 06:38 ZhangJian He <sh...@gmail.com> ha scritto:
> >
> > > Hello everyone, I have added checkstyle on pulsar-metadata, and
> > > UnusedImports check on test code. If your PR is involved in these two
> > > situations. Please pull the master code. Thanks
> > >
> >
> >
> > Got it
> >
> > Thanks
> > Enrico
> >
> > >
> > > Thanks
> > > ZhangJian He
> > >
Re: CheckStyle Rule Change
Posted by Ivan Kelly <iv...@apache.org>.
Maybe this has been discussed elsewhere, but if possible, we should
add a rule that to block any future log4shell type attack area.
In human terms, the rule should be:
Disallow any {log,logger,LOG}.* with a non-const first argument.
-Ivan
On Wed, Dec 15, 2021 at 7:15 AM Enrico Olivelli <eo...@gmail.com> wrote:
>
> Il Mer 15 Dic 2021, 06:38 ZhangJian He <sh...@gmail.com> ha scritto:
>
> > Hello everyone, I have added checkstyle on pulsar-metadata, and
> > UnusedImports check on test code. If your PR is involved in these two
> > situations. Please pull the master code. Thanks
> >
>
>
> Got it
>
> Thanks
> Enrico
>
> >
> > Thanks
> > ZhangJian He
> >
Re: CheckStyle Rule Change
Posted by Enrico Olivelli <eo...@gmail.com>.
Il Mer 15 Dic 2021, 06:38 ZhangJian He <sh...@gmail.com> ha scritto:
> Hello everyone, I have added checkstyle on pulsar-metadata, and
> UnusedImports check on test code. If your PR is involved in these two
> situations. Please pull the master code. Thanks
>
Got it
Thanks
Enrico
>
> Thanks
> ZhangJian He
>