You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/08 18:27:54 UTC
[GitHub] [maven-archetype] kwin opened a new pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
kwin opened a new pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60
interactive mode
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] kwin commented on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
Posted by GitBox <gi...@apache.org>.
kwin commented on pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-993303879
@slachiewicz I now rebased my PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] gunnarmorling commented on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
Posted by GitBox <gi...@apache.org>.
gunnarmorling commented on pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-981138823
Hey @hboutemy, pinging you as I saw you recently committed to this repo. I am interested in seeing a solution to this issue here, so I'm wondering what is missing in order to resolve it? I'd be willing to help if there's need for it. In terms of a solution, I think what's proposed here is good, only that'd I'd preferably make the new behavior the default (i.e. prompt for default options unless it's disabled explicitly). Alternatively, whether to prompt or not prompt could be a part of the archetype definition. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] slachiewicz commented on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-992997297
could you rebase PR - we have conflict here: 137461e8dd71a26f53d25aa9c58e29e04127d6a7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] slachiewicz merged pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetype] gunnarmorling edited a comment on pull request #60: [ARCHTYPE-308] optionally ask for properties with default values in
Posted by GitBox <gi...@apache.org>.
gunnarmorling edited a comment on pull request #60:
URL: https://github.com/apache/maven-archetype/pull/60#issuecomment-981138823
Hey @hboutemy, pinging you as I saw you recently committed to this repo. I am interested in seeing a solution to this issue here, so I'm wondering what is missing in order to resolve it? I'd be willing to help if there's need for it.
In terms of a solution, I think what's proposed here is good, only that'd I'd preferably make the new behavior the default (i.e. prompt for default options unless it's disabled explicitly). Alternatively, whether to prompt or not prompt could be a part of the archetype definition. WDYT?
// CC @rfscholte
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org