[GitHub] [pulsar] srkukarni commented on a change in pull request #4005: Set key for message when using function publish

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #4005: Set key for message when using function publish
URL: https://github.com/apache/pulsar/pull/4005#discussion_r273245375
 
 

 ##########
 File path: pulsar-client-cpp/python/pulsar/functions/context.py
 ##########
 @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value):
   @abstractmethod
   def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None):
     """Publishes message to topic_name by first serializing the message using serde_class_name serde
-    The message will have properties specified if any"""
+    The message will have properties specified if any
 
 Review comment:
   Not sure we want to always do it this way. For example, what if we have multiple input topics with different keys, etc. 
   Would it be better to explicitly have an extra parameter?(Both for java and py)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services