You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "aalmiray (via GitHub)" <gi...@apache.org> on 2023/04/28 17:34:32 UTC
[GitHub] [commons-jexl] aalmiray commented on a diff in pull request #177: JEXL-396: Add full Java module descriptor
aalmiray commented on code in PR #177:
URL: https://github.com/apache/commons-jexl/pull/177#discussion_r1180659678
##########
pom.xml:
##########
@@ -519,4 +519,48 @@
<name>Dmitri Blinov</name>
</contributor>
</contributors>
+
+ <profiles>
+ <profile>
+ <id>java-module</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.moditect</groupId>
+ <artifactId>moditect-maven-plugin</artifactId>
+ <version>1.0.0.RC3</version>
+ <executions>
+ <execution>
+ <id>add-module-infos</id>
+ <phase>package</phase>
+ <goals>
+ <goal>add-module-info</goal>
+ </goals>
+ <configuration>
+ <jvmVersion>9</jvmVersion>
+ <overwriteExistingFiles>true</overwriteExistingFiles>
+ <module>
+ <moduleInfo>
+ <name>${commons.module.name}</name>
+ <exports>
+ !org.apache.commons.jexl3.internal*;
Review Comment:
Updated as requested. force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org