You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2024/11/25 20:00:40 UTC
[PR] Update `upload-artifact` to use v4 [iceberg-python]
kevinjqliu opened a new pull request, #1371:
URL: https://github.com/apache/iceberg-python/pull/1371
Based on https://lists.apache.org/thread/nx19j3h61tjmsk8c8vx24gbq6ygf7pyf
`upload-artifact@v3` only used in iceberg-python
https://grep.app/search?q=actions/upload-artifact%40v3&filter[repo.pattern][0]=apache/iceberg
`download-artifact@v3` not used in any iceberg related repos
https://grep.app/search?q=actions/download-artifact&filter[repo.pattern][0]=apache/iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1857407764
##########
.github/workflows/python-release.yml:
##########
@@ -34,7 +34,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [ ubuntu-22.04, windows-2022, macos-12, macos-13, macos-14 ]
+ os: [ ubuntu-22.04, windows-2022, macos-13, macos-14 ]
Review Comment:
removed `macos-12` because its deprecated and causing the `merge` step to not run
https://github.com/kevinjqliu/iceberg-python/actions/runs/12018552791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2498948927
Thanks for bumping this, unfortunately, we've downgraded to `v3` a while ago https://github.com/apache/iceberg-python/pull/396
With V4 it does not combine the zip files, so we get 5 zip files that we need to unpack, and then combine again. With https://github.com/apache/iceberg-python/pull/1370 this would explode to 25 zips. While releasing iceberg-go I noticed that they use a very fancy script that gets the relevant information of the release PR through the GitHub API. This removes quite a few steps and might be a good idea to introduce here when we're going to `v4`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1857351157
##########
.github/workflows/python-release.yml:
##########
@@ -84,7 +84,16 @@ jobs:
if: startsWith(matrix.os, 'ubuntu')
run: ls -lah dist/* && cp dist/* wheelhouse/
- - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4
with:
- name: "release-${{ github.event.inputs.version }}"
+ name: "release-${{ matrix.os }}"
path: ./wheelhouse/*
+ merge:
Review Comment:
Ohh, this is nice! https://github.com/actions/upload-artifact/blob/main/merge/README.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501851589
@kevinjqliu Ah I see, I don't think that we have _fully_ reproducible builds. For example, if a timestamp in some wheel is different, then it would yield another hash. I think it is a nice feature to have, but not strickly required for the ASF releases AFAIK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on code in PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#discussion_r1858683932
##########
.github/workflows/python-release.yml:
##########
@@ -34,7 +34,7 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
- os: [ ubuntu-22.04, windows-2022, macos-12, macos-13, macos-14 ]
+ os: [ ubuntu-22.04, windows-2022, macos-13, macos-14 ]
Review Comment:
Good catch, I noticed that `macos-15` is also available. Maybe we can add that one as well. I checked it on my local branch, and it works over there: https://github.com/Fokko/iceberg-python/actions/runs/12033072248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501640410
I was comparing between running the action on [main](https://github.com/kevinjqliu/iceberg-python/actions/runs/12036359688) versus [this branch](https://github.com/kevinjqliu/iceberg-python/actions/runs/12035706304)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2499182778
@Fokko I double-checked the new artifacts, file names match but they have different hashes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Update `upload-artifact` to use v4 [iceberg-python]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on PR #1371:
URL: https://github.com/apache/iceberg-python/pull/1371#issuecomment-2501017013
@kevinjqliu Can you elaborate? I just pushed it to my own branch, and I see identical hashes:
```
➜ Downloads shasum -a 512 release-ubuntu-22.04/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
097dc7cc8cf214b3489e3c8facf66e08212570ca5f5d0cf16df88cd5b7839e76a2807e1326d80716ddb46bbbe4cdd423599ff3db0265cfd56c79ebe56678e39a release-ubuntu-22.04/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
➜ Downloads shasum -a 512 release-main/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
097dc7cc8cf214b3489e3c8facf66e08212570ca5f5d0cf16df88cd5b7839e76a2807e1326d80716ddb46bbbe4cdd423599ff3db0265cfd56c79ebe56678e39a release-main/pyiceberg-0.8.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org