You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Dave Brosius (JIRA)" <ji...@apache.org> on 2010/11/25 05:32:13 UTC
[jira] Created: (KARAF-299) [patch] miscellaneous cleanups
[patch] miscellaneous cleanups
------------------------------
Key: KARAF-299
URL: https://issues.apache.org/jira/browse/KARAF-299
Project: Karaf
Issue Type: Bug
Environment: ubuntu 10.10 java1.6.17
Reporter: Dave Brosius
Priority: Minor
Attachments: fixes.patch
removed unused allocations
fixed bad collection contains typing
fix bad result set column indexing
fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated KARAF-299:
-------------------------------
Attachment: bundleprobs.diff
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935754#action_12935754 ]
Guillaume Nodet commented on KARAF-299:
---------------------------------------
Is the fix on the Main class for changing the collection type correct ?
It seems the list contains BundleInfo and now we're looking for a Bundle, which is not worse, but not better either than the previous behavior.
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber reassigned KARAF-299:
------------------------------------
Assignee: Andreas Pieber (was: Jean-Baptiste Onofré)
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.3, 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935751#action_12935751 ]
Dave Brosius commented on KARAF-299:
------------------------------------
Thanks for applying.
The two question comments should be removed now that you have resolved them
main/src/main/java/org/apache/karaf/main/Main.java
webconsole/admin/src/main/java/org/apache/karaf/webconsole/admin/AdminPlugin.java
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber updated KARAF-299:
---------------------------------
Fix Version/s: 2.1.3
Fixed for trunk; fix should be backported to karaf-2.1.x
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.1.3, 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet reopened KARAF-299:
-----------------------------------
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber reopened KARAF-299:
----------------------------------
Reopen issue for backporting to karaf-2.1.x branch
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.1.3, 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Andreas Pieber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andreas Pieber resolved KARAF-299.
----------------------------------
Resolution: Fixed
also included in karaf-2.1.x:
Committed r1053848
Committed r1053849
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.3, 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Guillaume Nodet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Guillaume Nodet resolved KARAF-299.
-----------------------------------
Resolution: Fixed
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dave Brosius updated KARAF-299:
-------------------------------
Attachment: fixes.patch
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Priority: Minor
> Attachments: fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (KARAF-299) [patch] miscellaneous cleanups
Posted by "Jamie goodyear (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jamie goodyear closed KARAF-299.
--------------------------------
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Andreas Pieber
> Priority: Minor
> Fix For: 2.1.3, 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Dave Brosius (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12935768#action_12935768 ]
Dave Brosius commented on KARAF-299:
------------------------------------
darn it, you're right, my apologies.
perhaps it's supposed to be this (if so i've applied a new patch):
public Set<Feature> getFeaturesContainingBundle (Bundle bundle) throws Exception {
Set<Feature> features = new HashSet<Feature>();
for (Map<String, Feature> featureMap : this.getFeatures().values()) {
for (Feature f : featureMap.values()) {
for (BundleInfo bi : f.getBundles()) {
if (bi.getLocation().equals(bundle.getLocation())) {
features.add(f);
break;
}
}
}
}
return features;
}
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: bundleprobs.diff, fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré resolved KARAF-299.
----------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0
Revision 1038942.
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 2.2.0
>
> Attachments: fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (KARAF-299) [patch] miscellaneous cleanups
Posted by "Jean-Baptiste Onofré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Onofré reassigned KARAF-299:
------------------------------------------
Assignee: Jean-Baptiste Onofré
> [patch] miscellaneous cleanups
> ------------------------------
>
> Key: KARAF-299
> URL: https://issues.apache.org/jira/browse/KARAF-299
> Project: Karaf
> Issue Type: Bug
> Environment: ubuntu 10.10 java1.6.17
> Reporter: Dave Brosius
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Attachments: fixes.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> removed unused allocations
> fixed bad collection contains typing
> fix bad result set column indexing
> fixed bad variable swapping
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.