You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mina.apache.org by "Michael Jakl (JIRA)" <ji...@apache.org> on 2009/07/27 19:06:14 UTC

[jira] Resolved: (VYSPER-149) Pubsub Handlers hold state

     [ https://issues.apache.org/jira/browse/VYSPER-149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Jakl resolved VYSPER-149.
---------------------------------

    Resolution: Fixed

Removed the sender and receiver variables. I'm not happy with declaring the other variables (errorStanzaGenerator, root, idGenerator) static, keeping them dynamic is more flexible (for example for defining a handler for a different root).

> Pubsub Handlers hold state
> --------------------------
>
>                 Key: VYSPER-149
>                 URL: https://issues.apache.org/jira/browse/VYSPER-149
>             Project: VYSPER
>          Issue Type: Bug
>          Components: XEP0060 PubSub
>            Reporter: Bernd Fondermann
>            Assignee: Michael Jakl
>
> In r791956, sender and receiver where introduced as fields in AbstractPublishSubscribeIQHandler. Since Handlers must be stateless to work correctly, these fields should be removed
> Furthermore, as recommended some time ago, I'd suggest to remove any non-static fields from handlers to prevent side-effects, for example if we cluster handlers in the future or something similar

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.