You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Bojan Smojver <bo...@rexursive.com> on 2008/08/07 23:46:34 UTC

Type detection logic

On the back of PR 45513
(https://issues.apache.org/bugzilla/show_bug.cgi?id=45513), shouldn't we
be moving that piece of code that manually overrides detection for
particular platforms to the very end, like we had it in 1.2.x?

Patch is attached. Please review, as it would be a good idea to put this
into 1.3.3.

-- 
Bojan

Re: Type detection logic

Posted by "William A. Rowe, Jr." <wr...@rowe-clan.net>.
Bojan Smojver wrote:
> On Fri, 2008-08-08 at 07:46 +1000, Bojan Smojver wrote:
>> On the back of PR 45513
>> (https://issues.apache.org/bugzilla/show_bug.cgi?id=45513)
> 
> Looks like this was busted in
> http://svn.apache.org/viewvc?view=rev&revision=554963

Agreed; davi - any feedback on the proposed fix?

Re: Type detection logic

Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2008-08-08 at 07:46 +1000, Bojan Smojver wrote:
> On the back of PR 45513
> (https://issues.apache.org/bugzilla/show_bug.cgi?id=45513)

Looks like this was busted in
http://svn.apache.org/viewvc?view=rev&revision=554963

-- 
Bojan


Re: Type detection logic

Posted by Bojan Smojver <bo...@rexursive.com>.
On Fri, 2008-08-08 at 07:46 +1000, Bojan Smojver wrote:

> Patch is attached.

Just got feedback from the original bug reporter (Rainer Jung) and the
attached patch is incorrect. So, here is the patch submitted with the
bug report that fixes the issue on Solaris.

-- 
Bojan