You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by tr...@apache.org on 2006/09/06 07:58:14 UTC
svn commit: r440624 - /httpd/httpd/branches/2.2.x/STATUS
Author: trawick
Date: Tue Sep 5 22:58:14 2006
New Revision: 440624
URL: http://svn.apache.org/viewvc?view=rev&rev=440624
Log:
propose a concrete patch for backporting ap_get_server_version()
changes to 2.2.x without breaking existing modules
Modified:
httpd/httpd/branches/2.2.x/STATUS
Modified: httpd/httpd/branches/2.2.x/STATUS
URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS?view=diff&rev=440624&r1=440623&r2=440624
==============================================================================
--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Tue Sep 5 22:58:14 2006
@@ -175,8 +175,12 @@
(proxy_interpolatem, proxy_vars) which does not belong to the pingpong patch.
* mod_ext_filter: Handle filter names which include capital letters.
- PR 40323.
- Trunk patch, which applies:
- http://svn.apache.org/viewvc?view=rev&revision=440028
- +1: trawick, rpluem
-
+ PR 40323.
+ Trunk patch, which applies:
+ http://svn.apache.org/viewvc?view=rev&revision=440028
+ +1: trawick, rpluem
+
+ * full server version information in the error log at startup as well as server
+ status reports, regardless of ServerTokens
+ http://people.apache.org/~trawick/banner-2.2.x-rev1.txt
+ +1: trawick
Re: svn commit: r440624 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Jeff Trawick <tr...@gmail.com>.
On 9/6/06, Ruediger Pluem <rp...@apache.org> wrote:
>
>
> On 09/06/2006 07:58 AM, wrote:
> > Author: trawick
> > Date: Tue Sep 5 22:58:14 2006
> > New Revision: 440624
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=440624
> > Log:
> > propose a concrete patch for backporting ap_get_server_version()
> > changes to 2.2.x without breaking existing modules
> >
>
> > +
> > + * full server version information in the error log at startup as well as server
> > + status reports, regardless of ServerTokens
> > + http://people.apache.org/~trawick/banner-2.2.x-rev1.txt
>
> A few comments:
(blush)
Thanks for pointing out that mess!
Re: svn commit: r440624 - /httpd/httpd/branches/2.2.x/STATUS
Posted by Ruediger Pluem <rp...@apache.org>.
On 09/06/2006 07:58 AM, wrote:
> Author: trawick
> Date: Tue Sep 5 22:58:14 2006
> New Revision: 440624
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=440624
> Log:
> propose a concrete patch for backporting ap_get_server_version()
> changes to 2.2.x without breaking existing modules
>
> +
> + * full server version information in the error log at startup as well as server
> + status reports, regardless of ServerTokens
> + http://people.apache.org/~trawick/banner-2.2.x-rev1.txt
A few comments:
--- server/core.c (revision 440616)
+++ server/core.c (working copy)
+
+/* ap_get_server_version() is deprecated. ap_get_server_banner()
+ * provides the same semantics.
+ */
+AP_DECLARE(const char *) ap_get_server_version() {
+ return ap_get_server_banner();
+}
+
Some style nits. I would prefer the following lines:
/*
* ap_get_server_version() is deprecated. ap_get_server_banner()
* provides the same semantics.
*/
AP_DECLARE(const char *) ap_get_server_version(void)
{
return ap_get_server_banner();
}
--- include/ap_mmn.h (revision 440616)
+++ include/ap_mmn.h (working copy)
@@ -111,6 +111,8 @@
* proxy_server (minor)
* 20051115.2 (2.2.2) added inreslist member to proxy_conn_rec (minor)
* 20051115.3 (2.2.3) Added server_scheme member to server_rec (minor)
+ * 20051115.4 (2.2.4) Added ap_get_server_banner() and
+ * ap_get_server_description() (minor)
*/
You made a comment about the minor bump, but you forgot to do it :-).
Regards
Rüdiger