You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Joe Swatosh <jo...@gmail.com> on 2007/03/14 05:45:03 UTC

[patch] test_info.rb

Hi kou,

I know you don't want to use binary io on windows, but you may want to
consider this as an exception:

[[[
* subversion/bindings/swig/ruby/test/test_info.rb
 use binary file io on windows so the extra line ending nonsense isn't
 added to the data making it to the repo.
]]]

Index: subversion/bindings/swig/ruby/test/test_info.rb
===================================================================
--- subversion/bindings/swig/ruby/test/test_info.rb     (revision 23804)
+++ subversion/bindings/swig/ruby/test/test_info.rb     (working copy)
@@ -176,7 +176,7 @@
     file4_prop_key = "XXX"
     file4_prop_value = "YYY"
     File.open(file1_path, "w") {|f| f.puts "changed"}
-    File.open(file2_path, "w") {|f| f.puts "removed\nadded"}
+    File.open(file2_path, "wb") {|f| f.puts "removed\nadded"}
     FileUtils.touch(file4_path)
     ctx.add(file4_path)
     ctx.propdel(file1_prop_key, file1_path)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [patch] test_info.rb

Posted by Kouhei Sutou <ko...@cozmixng.org>.
Hi Joe,


In <ae...@mail.gmail.com>
  "[patch] test_info.rb" on Tue, 13 Mar 2007 22:45:03 -0700,
  "Joe Swatosh" <jo...@gmail.com> wrote:

> I know you don't want to use binary io on windows, but you may want to
> consider this as an exception:
> 
> [[[
> * subversion/bindings/swig/ruby/test/test_info.rb
>  use binary file io on windows so the extra line ending nonsense isn't
>  added to the data making it to the repo.
> ]]]

OK. I've committed in r23811.


Thanks,
--
kou

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org