[GitHub] [incubator-pinot] siddharthteotia commented on a change in pull request #6731: Fix an issue with datetime column in Rule Engine

[GitBox <gi...@apache.org>]

siddharthteotia commented on a change in pull request #6731:
URL: https://github.com/apache/incubator-pinot/pull/6731#discussion_r605235846



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/recommender/io/InputManager.java
##########
@@ -181,15 +182,19 @@ private void validateQueries() {
     invalidQueries.forEach(_queryWeightMap::remove);
   }
 
-  public void registerColnameFieldType() { // create a map from colname to data type
+  public void registerColNameFieldType() { // create a map from col name to data type

Review comment:
       Not related to the changes in this PR but can we do the following cleanup ?
   - Make this private. It is not used elsewhere.
   - Move the javadoc to one line before. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org