You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/01 08:57:43 UTC
[GitHub] HeartSaVioR edited a comment on issue #23720: WIP for discussion:
create attributes from log urls
HeartSaVioR edited a comment on issue #23720: WIP for discussion: create attributes from log urls
URL: https://github.com/apache/spark/pull/23720#issuecomment-459651796
Hmm... got it. I don't have strong preference so let's see others' voice. Btw I think we should have preference to attributes and regex group (which is less stable than attributes), or maybe more ideally merge two attributes. Your patch looks to use attributes as a fail-back which could effectively disable the feature for newer apps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org