You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2025/09/12 12:39:59 UTC
[PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
dpgaspar opened a new pull request, #35117:
URL: https://github.com/apache/superset/pull/35117
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-4041736499
@dpgaspar do you still intend to get this through? Needs a big ol' rebase, but seems like important work :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-3285134550
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
[](78f1d178-00c4-45db-8a6f-984b9ca3cf9f)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rad-pat (via GitHub)" <gi...@apache.org>.
rad-pat commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-4729106428
> @dpgaspar @rusackas do you want any help to get this over the line? I believe that getting updated to SQLA 2.0 is pretty important since 1.4 is EOL
I see there are quite a number of other PRs related to trying to migrate SQLAlchemy. Perhaps some should be closed off, like this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rad-pat (via GitHub)" <gi...@apache.org>.
rad-pat commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-4706282044
@dpgaspar @rusackas do you want any help to get this over the line? I believe that getting updated to SQLA 2.0 is pretty important since 1.4 is EOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-4783189248
Yeah, you're right... the effort is moving forward, this PR doesn't seem to be. Closing for now, but happy to reopen, or @dpgaspar can do the same if he wants to :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rad-pat (via GitHub)" <gi...@apache.org>.
rad-pat commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-3599202323
Any idea on estimated timeline for this compatibility with SQLAlchemy 2.0? No further releases expected for SQLAlchemy 1.4, it is EOL according to Mike Bayer - https://github.com/sqlalchemy/sqlalchemy/discussions/13009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #35117:
URL: https://github.com/apache/superset/pull/35117#issuecomment-4665777842
@dpgaspar this hit my stale draft radar again... not sure if you're picking this back up, but I might close it out next time it hits 90+ days again to thin the herd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: Support Flask 3.X and SQLAlchemy 2.X [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #35117: chore: Support Flask 3.X and SQLAlchemy 2.X
URL: https://github.com/apache/superset/pull/35117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org