You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/15 05:05:16 UTC

[GitHub] [superset] suddjian commented on a change in pull request #17757: feat: Authorizing guest access to embedded dashboards

suddjian commented on a change in pull request #17757:
URL: https://github.com/apache/superset/pull/17757#discussion_r769243843



##########
File path: superset/common/request_contexed_based.py
##########
@@ -16,24 +16,10 @@
 # under the License.
 from __future__ import annotations
 
-from typing import List, TYPE_CHECKING
-
-from flask import g
-
 from superset import conf, security_manager
 
-if TYPE_CHECKING:
-    from flask_appbuilder.security.sqla.models import Role
-
-
-def get_user_roles() -> List[Role]:

Review comment:
       Since we had to change this method, and there were two identical methods in different files, we decided to move it into the security manager where it belongs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org