You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Jarek Gawor <jg...@gmail.com> on 2011/05/04 21:39:32 UTC
OBR - FELIX-2912
Hi,
I was wondering if somebody could review & possibly commit the patch
attached to FELIX-2912 for the bundlerepository module.
Thanks,
Jarek
Re: OBR - FELIX-2912
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 5/4/11 4:02 PM, Richard S. Hall wrote:
> On 5/4/11 15:39, Jarek Gawor wrote:
>> I was wondering if somebody could review& possibly commit the patch
>> attached to FELIX-2912 for the bundlerepository module.
>
> The patch in and of itself seems ok, but generally speaking it seems
> like a specific special case for a situation that could have lots of
> similar special cases. What if there are other types of exceptions
> that get thrown and similarly provide inadequate reporting. Will we
> need a bunch of different catch clauses converting them into something
> more meaningful?
>
> Is there a more general approach to solve this issue? What always
Sorry, that should have said, "What about always..."
> catching any IOException and rethrowing another IOException that
> includes the full URL of what we were trying to open in its message
> along with the exception that caused this in the first place?
>
> Would that give you enough of the information you want in this case?
> Just wondering...
>
> -> richard
Re: OBR - FELIX-2912
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 5/11/11 10:42, Jarek Gawor wrote:
> On Wed, May 4, 2011 at 4:02 PM, Richard S. Hall<he...@ungoverned.org> wrote:
>> On 5/4/11 15:39, Jarek Gawor wrote:
>>> I was wondering if somebody could review& possibly commit the patch
>>> attached to FELIX-2912 for the bundlerepository module.
>> The patch in and of itself seems ok, but generally speaking it seems like a
>> specific special case for a situation that could have lots of similar
>> special cases. What if there are other types of exceptions that get thrown
>> and similarly provide inadequate reporting. Will we need a bunch of
>> different catch clauses converting them into something more meaningful?
>>
>> Is there a more general approach to solve this issue? What always catching
>> any IOException and rethrowing another IOException that includes the full
>> URL of what we were trying to open in its message along with the exception
>> that caused this in the first place?
>>
>> Would that give you enough of the information you want in this case? Just
>> wondering...
> Sure. I just attached another patch for FELIX-2912 that follows your
> suggestion to catch any IOException. Let me know if that works for
> you.
I committed it. Please close this issue if you are happy. Thanks!
-> richard
> Thanks,
> Jarek
Re: OBR - FELIX-2912
Posted by Jarek Gawor <jg...@gmail.com>.
On Wed, May 4, 2011 at 4:02 PM, Richard S. Hall <he...@ungoverned.org> wrote:
> On 5/4/11 15:39, Jarek Gawor wrote:
>>
>> I was wondering if somebody could review& possibly commit the patch
>> attached to FELIX-2912 for the bundlerepository module.
>
> The patch in and of itself seems ok, but generally speaking it seems like a
> specific special case for a situation that could have lots of similar
> special cases. What if there are other types of exceptions that get thrown
> and similarly provide inadequate reporting. Will we need a bunch of
> different catch clauses converting them into something more meaningful?
>
> Is there a more general approach to solve this issue? What always catching
> any IOException and rethrowing another IOException that includes the full
> URL of what we were trying to open in its message along with the exception
> that caused this in the first place?
>
> Would that give you enough of the information you want in this case? Just
> wondering...
Sure. I just attached another patch for FELIX-2912 that follows your
suggestion to catch any IOException. Let me know if that works for
you.
Thanks,
Jarek
Re: OBR - FELIX-2912
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 5/4/11 15:39, Jarek Gawor wrote:
> I was wondering if somebody could review& possibly commit the patch
> attached to FELIX-2912 for the bundlerepository module.
The patch in and of itself seems ok, but generally speaking it seems
like a specific special case for a situation that could have lots of
similar special cases. What if there are other types of exceptions that
get thrown and similarly provide inadequate reporting. Will we need a
bunch of different catch clauses converting them into something more
meaningful?
Is there a more general approach to solve this issue? What always
catching any IOException and rethrowing another IOException that
includes the full URL of what we were trying to open in its message
along with the exception that caused this in the first place?
Would that give you enough of the information you want in this case?
Just wondering...
-> richard