You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2022/04/25 14:47:26 UTC
[GitHub] [tomcat] jeanouii opened a new pull request, #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined
jeanouii opened a new pull request, #505:
URL: https://github.com/apache/tomcat/pull/505
An issue as been introduced in JasperInitializer with commit https://github.com/apache/tomcat/commit/5e8eb5533f551c3dbc3003e4c2f4f0d2958a8eb3
When a default JspFactory is already defined the static field `defaultFactory` in JasperInitializer isn't initialized. It produces a NullPointerException line 108 when setting the poolSize.
This fix enforces a proper initialization even when the default JspFactory is already set.
Adding a small test checking the PoolSize can be set using the ServletContext and therefor the bug as been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher commented on pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined
Posted by GitBox <gi...@apache.org>.
rmaucher commented on PR #505:
URL: https://github.com/apache/tomcat/pull/505#issuecomment-1108763955
Adding this field was a bad idea. I'm removing it now instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] jeanouii commented on pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined
Posted by GitBox <gi...@apache.org>.
jeanouii commented on PR #505:
URL: https://github.com/apache/tomcat/pull/505#issuecomment-1108775222
I first had the same though. Why not just using the API and call getDefaultFactory. Thanks Remy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] rmaucher closed pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined
Posted by GitBox <gi...@apache.org>.
rmaucher closed pull request #505: JasperInitializer not correctly initialized when a Default JspFactory is already defined
URL: https://github.com/apache/tomcat/pull/505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org