You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 01:35:49 UTC

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #3612: Simplify serialization by removing redundant `PrimitiveScalarValue`

tustvold commented on code in PR #3612:
URL: https://github.com/apache/arrow-datafusion/pull/3612#discussion_r1002816676


##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -762,8 +762,9 @@ message StructValue {
 
 message ScalarValue{
     oneof value {
-        // Null value of any type (type is encoded)
-        PrimitiveScalarType null_value = 19;
+        // was PrimitiveScalarType null_value = 19;

Review Comment:
   Technically you should `reserve 19`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org