[jira] [Commented] (TAJO-2170) Disable unsetting timezone property

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15442943#comment-15442943 ] 

ASF GitHub Bot commented on TAJO-2170:
--------------------------------------

Github user jinossy commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/1045#discussion_r76527387
  
    --- Diff: tajo-catalog/tajo-catalog-server/src/main/java/org/apache/tajo/catalog/store/AbstractDBStore.java ---
    @@ -1110,12 +1113,20 @@ private void setProperties(final int tableId, final KeyValueSetProto properties)
         }
       }
     
    -  private void unsetProperties(final int tableId, final PrimitiveProtos.StringListProto propertyKeys) {
    +  private void unsetProperties(final int tableId, final PrimitiveProtos.StringListProto propertyKeys)
    +      throws UnremovableTablePropertyException {
         final String deleteSql = "DELETE FROM " + TB_OPTIONS + " WHERE TID=? AND KEY_=?";
     
         Connection conn;
         PreparedStatement pstmt = null;
     
    +	  Set<String> keys = Sets.newHashSet(propertyKeys.getValuesList());
    --- End diff --
    
    Please fix indentation in this code block
    https://cwiki.apache.org/confluence/display/TAJO/Code+Style
    Thanks


> Disable unsetting timezone property
> -----------------------------------
>
>                 Key: TAJO-2170
>                 URL: https://issues.apache.org/jira/browse/TAJO-2170
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Lee Dongjin
>            Assignee: Lee Dongjin
>
> Dislike to the other table properties, timezone became a mandatory one recently. We have to move it to separated variable and disable the way to unset it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)