[GitHub] [doris] zhannngchen commented on a diff in pull request #11205: [feature-wip](unique-key-merge-on-write) remove AggType on unique table with MoW, enable preAggreation, DSIP-018[5/2]

[GitBox <gi...@apache.org>]

zhannngchen commented on code in PR #11205:
URL: https://github.com/apache/doris/pull/11205#discussion_r929746562


##########
be/src/olap/memtable.cpp:
##########
@@ -64,8 +64,8 @@ MemTable::MemTable(int64_t tablet_id, Schema* schema, const TabletSchema* tablet
         } else {
             _insert_fn = &MemTable::_insert_agg;
         }
-        if (_tablet_schema->has_sequence_col()) {
-            _aggregate_two_row_fn = &MemTable::_aggregate_two_row_with_sequence;

Review Comment:
   This part of code is not removed, just move to `_aggregate_two_row`, it works quite similar like the method `_aggregate_two_row_in_block`.
   For the unique table without MoW(merge-on-write), they all proceeded by the method `_aggregate_two_row`, no necessary to separate to 2 methods.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org