You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/23 04:04:33 UTC
[GitHub] [spark] rxin opened a new pull request, #39189: Add a CTE subquery scope test case.
rxin opened a new pull request, #39189:
URL: https://github.com/apache/spark/pull/39189
### What changes were proposed in this pull request?
I noticed we were missing a test case for this in SQL tests.
### Why are the changes needed?
To ensure we scope CTEs properly in subqueries.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
This is a test case change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HeartSaVioR commented on pull request #39189: [MINOR][TEST][SQL] Add a CTE subquery scope test case.
Posted by GitBox <gi...@apache.org>.
HeartSaVioR commented on PR #39189:
URL: https://github.com/apache/spark/pull/39189#issuecomment-1366473331
@rxin @cloud-fan @HyukjinKwon
Looks like this broke branch-3.3 as error class framework does not exist in Spark 3.3. Shall we revert this in branch-3.3, or do we want (someone) to fix this quickly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rxin closed pull request #39189: [MINOR][TEST][SQL] Add a CTE subquery scope test case.
Posted by GitBox <gi...@apache.org>.
rxin closed pull request #39189: [MINOR][TEST][SQL] Add a CTE subquery scope test case.
URL: https://github.com/apache/spark/pull/39189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #39189: [MINOR][TEST][SQL] Add a CTE subquery scope test case.
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on PR #39189:
URL: https://github.com/apache/spark/pull/39189#issuecomment-1366481447
I have reverted it from 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org