[jira] [Commented] (IMPALA-8330) Impala shell --config_file should use flag names and not dest variable names

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-8330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805222#comment-16805222 ] 

ASF subversion and git services commented on IMPALA-8330:
---------------------------------------------------------

Commit 7adb411bd99812d30e2a8cf795557746591df15e in impala's branch refs/heads/master from Fredy Wijaya
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7adb411 ]

IMPALA-8330: Impala shell config file should support flag names

This patch updates the file format in Impala shell config file to accept
both short and long flag names in addition to optparse's dest names
(variable names to store flag values) for better user experience because
dest names are internal to Impala shell.

Format:
[impala]
flag_name=flag_value

Example:
[impala]
; This is long flag.
query=select 1
; This is short flag.
Q=DEFAULT_FILE_FORMAT=parquet
; Flags can be repeated with ,
var=msg1=hello,var=msg2=world
; The old format using internal variable name is still supported for
; backward compatibility.
keyval=msg3=foo,keyval=msg4=bar

Testing:
- Ran all E2E shell tests on Python 2.6 and 2.7.

Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9
Reviewed-on: http://gerrit.cloudera.org:8080/12823
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Impala shell --config_file should use flag names and not dest variable names
> ----------------------------------------------------------------------------
>
>                 Key: IMPALA-8330
>                 URL: https://issues.apache.org/jira/browse/IMPALA-8330
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Clients
>    Affects Versions: Impala 3.0, Impala 2.12.0
>            Reporter: Fredy Wijaya
>            Assignee: Fredy Wijaya
>            Priority: Major
>              Labels: compatibility
>
> --config_file in Impala shell uses "dest" variable names and not flag names due to: https://github.com/apache/impala/blob/master/shell/option_parser.py#L132
> This is confusing because the users may not know what the dest variable names are without looking at the Impala shell source code. We should either make the dest variable names the same as flag names or modify the Impala shell code to use the flag names.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org