You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/05/06 05:10:59 UTC
[GitHub] [james-project] quantranhong1999 opened a new pull request, #991: JAMES-3744 JMAP POST endpoint's URI matcher should be more flexible
quantranhong1999 opened a new pull request, #991:
URL: https://github.com/apache/james-project/pull/991
This allows matching JMAP POST routes with query param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa merged pull request #991: JAMES-3744 Fixed URI matcher should be more flexible
Posted by GitBox <gi...@apache.org>.
chibenwa merged PR #991:
URL: https://github.com/apache/james-project/pull/991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #991: JAMES-3744 JMAP POST endpoint's URI matcher should be more flexible
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #991:
URL: https://github.com/apache/james-project/pull/991#issuecomment-1119275604
Can we have a unit test in JMAP tooling reproducing what you try to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #991: JAMES-3744 JMAP POST endpoint's URI matcher should be more flexible
Posted by GitBox <gi...@apache.org>.
chibenwa commented on PR #991:
URL: https://github.com/apache/james-project/pull/991#issuecomment-1119277774
IMO Fixed UtiMatcher could be made smarter to ignore query parameters, IE if the matched sting contains `?` we instead took the substring until `?`. Would it solves your problem too?
A unit test for Fixed Uri matcher would then be enough to me to back this changeset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org