You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/04/13 19:41:34 UTC

[GitHub] [maven] cstamas opened a new pull request, #1089: [MNG-7670] Update misc dependencies

cstamas opened a new pull request, #1089:
URL: https://github.com/apache/maven/pull/1089

   And do align them. Max Level is Java 8, but
   we had several conflicts, like HttpClient
   (used by Wagon but also by Resolver-Transport-Http).
   
   ---
   
   https://issues.apache.org/jira/browse/MNG-7670


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #1089: [MNG-7670] Update misc dependencies

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1089:
URL: https://github.com/apache/maven/pull/1089#issuecomment-1511268488

   > @michael-o so this PR is okay?
   
   Yes, this is OK, if all ITs pass and if it is a sole CLI update w/o back porting the code from master. Honestly, I would back port the code from master with a separate issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] cstamas commented on pull request #1089: [MNG-7670] Update misc dependencies

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1089:
URL: https://github.com/apache/maven/pull/1089#issuecomment-1507545144

   @michael-o on JIRA you mention "Commons CLI must not be touched because the upgrade requires also code changes. See master.". What code changes you mean here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] cstamas commented on pull request #1089: [MNG-7670] Update misc dependencies

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1089:
URL: https://github.com/apache/maven/pull/1089#issuecomment-1511271417

   @michael-o so you approve it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] cstamas merged pull request #1089: [MNG-7670] Update misc dependencies

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1089:
URL: https://github.com/apache/maven/pull/1089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] cstamas commented on pull request #1089: [MNG-7670] Update misc dependencies

Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1089:
URL: https://github.com/apache/maven/pull/1089#issuecomment-1511243171

   @michael-o so this PR is okay?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on pull request #1089: [MNG-7670] Update misc dependencies

Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1089:
URL: https://github.com/apache/maven/pull/1089#issuecomment-1510944227

   > @michael-o on JIRA you mention "Commons CLI must not be touched because the upgrade requires also code changes. See master.". What code changes you mean here?
   > 
   > I found this [4476026](https://github.com/apache/maven/commit/4476026c525a22900c6c5e4f0de6f7362cb201f2) but here parser is changed. Is it necessary? GnuParser is already deprecated (was in 1.3), but imho does not require code change, or I miss somethin?
   
   The migration introduces a slight incompat problem. That is why we did not touch it in 3.x. The previous impl was ugly, now I'd say that it is correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org