You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2006/03/27 04:51:15 UTC
svn commit: r389008 -
/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Author: dion
Date: Sun Mar 26 18:51:12 2006
New Revision: 389008
URL: http://svn.apache.org/viewcvs?rev=389008&view=rev
Log:
Added todo
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
Modified: jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java?rev=389008&r1=389007&r2=389008&view=diff
==============================================================================
--- jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java (original)
+++ jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/ExpressionFactory.java Sun Mar 26 18:51:12 2006
@@ -131,18 +131,14 @@
// throw an exception.
SimpleNode node = (SimpleNode) tree.jjtGetChild(0);
- if( (node instanceof ASTReferenceExpression)
- || (node instanceof ASTExpressionExpression)
- || (node instanceof ASTStatementExpression))
- {
- node = (SimpleNode) node.jjtGetChild(0);
- Expression e = new ExpressionImpl(expression, node);
-
- return e;
- }
- else if (node instanceof ASTIfStatement
- || node instanceof ASTWhileStatement
- || node instanceof ASTForeachStatement)
+ // TODO: Can we get rid of these checks?
+ if( node instanceof ASTReferenceExpression
+ || node instanceof ASTExpressionExpression
+ || node instanceof ASTStatementExpression
+ || node instanceof ASTIfStatement
+ || node instanceof ASTWhileStatement
+ || node instanceof ASTForeachStatement
+ )
{
return new ExpressionImpl(expression, node);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org