You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2015/05/02 07:00:13 UTC

[jira] [Commented] (HADOOP-11095) How about Null check when closing inputstream object in JavaKeyStoreProvider#() ?

    [ https://issues.apache.org/jira/browse/HADOOP-11095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524936#comment-14524936 ] 

Hadoop QA commented on HADOOP-11095:
------------------------------------

\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | patch |   0m  0s | The patch command could not apply the patch during dryrun. |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL | http://issues.apache.org/jira/secure/attachment/12669043/HADOOP-11095_001.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / f1a152c |
| Console output | https://builds.apache.org/job/PreCommit-HADOOP-Build/6361/console |


This message was automatically generated.

> How about Null check when closing inputstream object in JavaKeyStoreProvider#() ?
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-11095
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11095
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.5.1
>            Reporter: skrho
>            Priority: Minor
>         Attachments: HADOOP-11095_001.patch
>
>
> In the finally block:
>           InputStream is = pwdFile.openStream();
>           try {
>             password = IOUtils.toCharArray(is);
>           } finally {
>             is.close();
>           }
>           
> How about Null check when closing inputstream object?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)