[GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #12151: test(dashboard): fix flaky Cypress test

[GitBox <gi...@apache.org>]

graceguo-supercat commented on a change in pull request #12151:
URL: https://github.com/apache/incubator-superset/pull/12151#discussion_r547032722



##########
File path: superset-frontend/cypress-base/cypress/integration/dashboard/filter.test.ts
##########
@@ -80,9 +82,8 @@ describe('Dashboard filter', () => {
     cy.get('.Select__menu').first().contains('South Asia').click();
 
     // should still have all filter indicators
-    // and since the select is closed, all filter indicators should be visible
     cy.get('svg[data-test="filter"]:visible').should(nodes => {
-      expect(nodes).to.have.length(10);
+      expect(nodes.length).to.least(9);

Review comment:
       there are 10 charts in the dashboard, in which there is 1 filter_box and 9 other charts. How can we expect > 9 filter indicators? (filter_box should never show indictor for itself)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org