You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/04/30 15:44:15 UTC

[jira] [Commented] (COLLECTIONS-459) ArrayIterator & ObjectArrayIterator - do they need setters?`

    [ https://issues.apache.org/jira/browse/COLLECTIONS-459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645576#comment-13645576 ] 

Thomas Neidhart commented on COLLECTIONS-459:
---------------------------------------------

I would be +1 to remove the setArray method in these two classes.
                
> ArrayIterator & ObjectArrayIterator - do they need setters?`
> ------------------------------------------------------------
>
>                 Key: COLLECTIONS-459
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-459
>             Project: Commons Collections
>          Issue Type: Bug
>            Reporter: Sebb
>
> ArrayIterator & ObjectArrayIterator both have methods to set the array separately from the ctor.
> However the method does not allow the same flexibility as the ctor, as it does not allow the start or end indexes to be set.
> Is there really a use-case for these setters? If not, all the fields apart from index could be made final, which would make thread safety (and testing) easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira