You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2010/12/10 14:30:01 UTC
[jira] Created: (HTTPCORE-248) HttpRoute.equals(Object o) is quite
inefficient, as it does not take full advantage of shortcut logic
HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
-----------------------------------------------------------------------------------------------------
Key: HTTPCORE-248
URL: https://issues.apache.org/jira/browse/HTTPCORE-248
Project: HttpComponents HttpCore
Issue Type: Improvement
Components: HttpCore
Affects Versions: 4.1
Reporter: Sebb
HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic.
It should return as soon as the first false is detected.
Patch to follow implements short-circuit checking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCORE-248) HttpRoute.equals(Object o) is
quite inefficient, as it does not take full advantage of shortcut logic
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970169#action_12970169 ]
Oleg Kalnichevski commented on HTTPCORE-248:
--------------------------------------------
Looks good to me.
Oleg
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
> -----------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-248
> URL: https://issues.apache.org/jira/browse/HTTPCORE-248
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.1
> Reporter: Sebb
> Attachments: HTTPCORE-248.patch
>
>
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic.
> It should return as soon as the first false is detected.
> Patch to follow implements short-circuit checking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-1033) HttpRoute.equals(Object o) is
quite inefficient, as it does not take full advantage of shortcut logic
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb resolved HTTPCLIENT-1033.
------------------------------
Resolution: Fixed
OK, applied
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
> -----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1033
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1033
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpConn
> Affects Versions: 4.1 Beta1
> Reporter: Sebb
> Attachments: HTTPCORE-248.patch
>
>
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic.
> It should return as soon as the first false is detected.
> Patch to follow implements short-circuit checking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCORE-248) HttpRoute.equals(Object o) is quite
inefficient, as it does not take full advantage of shortcut logic
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCORE-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb updated HTTPCORE-248:
--------------------------
Attachment: HTTPCORE-248.patch
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
> -----------------------------------------------------------------------------------------------------
>
> Key: HTTPCORE-248
> URL: https://issues.apache.org/jira/browse/HTTPCORE-248
> Project: HttpComponents HttpCore
> Issue Type: Improvement
> Components: HttpCore
> Affects Versions: 4.1
> Reporter: Sebb
> Attachments: HTTPCORE-248.patch
>
>
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic.
> It should return as soon as the first false is detected.
> Patch to follow implements short-circuit checking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Moved: (HTTPCLIENT-1033) HttpRoute.equals(Object o) is quite
inefficient, as it does not take full advantage of shortcut logic
Posted by "Sebb (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sebb moved HTTPCORE-248 to HTTPCLIENT-1033:
-------------------------------------------
Component/s: (was: HttpCore)
HttpConn
Affects Version/s: (was: 4.1)
4.1 Beta1
Issue Type: Bug (was: Improvement)
Key: HTTPCLIENT-1033 (was: HTTPCORE-248)
Project: HttpComponents HttpClient (was: HttpComponents HttpCore)
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic
> -----------------------------------------------------------------------------------------------------
>
> Key: HTTPCLIENT-1033
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1033
> Project: HttpComponents HttpClient
> Issue Type: Bug
> Components: HttpConn
> Affects Versions: 4.1 Beta1
> Reporter: Sebb
> Attachments: HTTPCORE-248.patch
>
>
> HttpRoute.equals(Object o) is quite inefficient, as it does not take full advantage of shortcut logic.
> It should return as soon as the first false is detected.
> Patch to follow implements short-circuit checking.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org