You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/26 08:46:13 UTC
[GitHub] [apisix-python-plugin-runner] Chever-John opened a new pull request, #51: fix: fix error when forwarding tff files
Chever-John opened a new pull request, #51:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/51
fix issue #50
Just add a judgment statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-python-plugin-runner] shuaijinchao commented on pull request #51: fix: fix error when forwarding tff files
Posted by GitBox <gi...@apache.org>.
shuaijinchao commented on PR #51:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110482418
Add test cases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-python-plugin-runner] Chever-John commented on pull request #51: fix: fix error when forwarding tff files
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #51:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1109525159
@spacewander Plz give me a approval :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-python-plugin-runner] Chever-John commented on pull request #51: fix: fix error when forwarding tff files
Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #51:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110494499
> Add test cases?
Yeah~
I will do it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-python-plugin-runner] codecov[bot] commented on pull request #51: fix: fix error when forwarding tff files
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #51:
URL: https://github.com/apache/apisix-python-plugin-runner/pull/51#issuecomment-1110482648
# [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#51](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5d0d5f) into [master](https://codecov.io/gh/apache/apisix-python-plugin-runner/commit/3de14f8295c5d06fd56651184667b020d06d0017?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3de14f8) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head c5d0d5f differs from pull request most recent head 1a0ccde. Consider uploading reports for the commit 1a0ccde to get more accurate results
```diff
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 91.72% 91.77% +0.05%
==========================================
Files 11 11
Lines 749 754 +5
==========================================
+ Hits 687 692 +5
Misses 62 62
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [apisix/runner/utils/common.py](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXBpc2l4L3J1bm5lci91dGlscy9jb21tb24ucHk=) | `98.65% <100.00%> (+0.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3de14f8...1a0ccde](https://codecov.io/gh/apache/apisix-python-plugin-runner/pull/51?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org