You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2019/11/12 19:34:50 UTC
[GitHub] [accumulo] keith-turner commented on a change in pull request
#1422: Fixes #1225 - Created a single ZooNode that tracks changes for all
table configs
keith-turner commented on a change in pull request #1422: Fixes #1225 - Created a single ZooNode that tracks changes for all table configs
URL: https://github.com/apache/accumulo/pull/1422#discussion_r345402226
##########
File path: core/src/main/java/org/apache/accumulo/fate/zookeeper/ZooCache.java
##########
@@ -148,14 +159,20 @@ private ZooKeeper getZooKeeper() {
}
private class ZCacheWatcher implements Watcher {
+
@Override
public void process(WatchedEvent event) {
if (log.isTraceEnabled()) {
log.trace("{}", event);
}
+ setWatcherForTableConfigVersion(event);
Review comment:
Will an event always trigger this and set it up? Could this be called in constructor instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services