You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "jchen5 (via GitHub)" <gi...@apache.org> on 2023/12/19 15:42:33 UTC

[PR] [SPARK-46446][SQL][Followup] Fix sql tests for subqueries with correlated OFFSET [spark]

jchen5 opened a new pull request, #44415:
URL: https://github.com/apache/spark/pull/44415

   ### What changes were proposed in this pull request?
   Follow-up PR for https://github.com/apache/spark/pull/44401, I had some minor test fixes that didn't get included in that PR.
   
   ### Why are the changes needed?
   Fix tests
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Tests themselves
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46446][SQL][Followup] Fix sql tests for subqueries with correlated OFFSET [spark]

Posted by "jchen5 (via GitHub)" <gi...@apache.org>.
jchen5 commented on PR #44415:
URL: https://github.com/apache/spark/pull/44415#issuecomment-1863486668

   @cloud-fan 
   
   Test fails look unrelated


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46446][SQL][FOLLOW-UP] Fix sql tests for subqueries with correlated OFFSET [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #44415:
URL: https://github.com/apache/spark/pull/44415#issuecomment-1863887663

   the test failure is unrelated, thanks, merging to master!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-46446][SQL][FOLLOW-UP] Fix sql tests for subqueries with correlated OFFSET [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #44415: [SPARK-46446][SQL][FOLLOW-UP] Fix sql tests for subqueries with correlated OFFSET
URL: https://github.com/apache/spark/pull/44415


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org