You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by re...@apache.org on 2019/06/14 11:47:29 UTC
[hbase] branch branch-1 updated: HBASE-22562 Remove dead code:
skipControl
This is an automated email from the ASF dual-hosted git repository.
reidchan pushed a commit to branch branch-1
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-1 by this push:
new 84af2a4 HBASE-22562 Remove dead code: skipControl
84af2a4 is described below
commit 84af2a46109da2b47d3b935d847b78149587af5f
Author: Josh Elser <el...@apache.org>
AuthorDate: Wed Jun 12 19:15:14 2019 -0400
HBASE-22562 Remove dead code: skipControl
Signed-off-by: Reid Chan <re...@apache.org>
---
.../throttle/PressureAwareCompactionThroughputController.java | 9 ---------
.../throttle/PressureAwareFlushThroughputController.java | 6 ------
.../regionserver/throttle/PressureAwareThroughputController.java | 8 --------
3 files changed, 23 deletions(-)
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java
index 2dc5817..b24555a 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareCompactionThroughputController.java
@@ -146,13 +146,4 @@ public class PressureAwareCompactionThroughputController extends PressureAwareTh
+ throughputDesc(getMaxThroughput()) + ", activeCompactions=" + activeOperations.size()
+ "]";
}
-
- @Override
- protected boolean skipControl(long deltaSize, long controlSize) {
- if (deltaSize < controlSize) {
- return true;
- } else {
- return false;
- }
- }
}
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java
index f301a27..ccb60ff 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareFlushThroughputController.java
@@ -127,10 +127,4 @@ public class PressureAwareFlushThroughputController extends PressureAwareThrough
return "DefaultFlushController [maxThroughput=" + throughputDesc(getMaxThroughput())
+ ", activeFlushNumber=" + activeOperations.size() + "]";
}
-
- @Override
- protected boolean skipControl(long deltaSize, long controlSize) {
- // for flush, we control the flow no matter whether the flush size is small
- return false;
- }
}
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareThroughputController.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareThroughputController.java
index 8867611..854d245 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareThroughputController.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/throttle/PressureAwareThroughputController.java
@@ -137,14 +137,6 @@ public abstract class PressureAwareThroughputController extends Configured imple
return sleepTime;
}
- /**
- * Check whether to skip control given delta size and control size
- * @param deltaSize Delta size since last control
- * @param controlSize Size limit to perform control
- * @return a boolean indicates whether to skip this control
- */
- protected abstract boolean skipControl(long deltaSize, long controlSize);
-
@Override
public void finish(String opName) {
ActiveOperation operation = activeOperations.remove(opName);