You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/10/22 21:44:12 UTC
[PR] Fix Pytest caplog after PR #43153 [airflow]
jscheffl opened a new pull request, #43279:
URL: https://github.com/apache/airflow/pull/43279
PR #43153 introduced some tests using caplog - which is known to have concurrency issues... and as the added tests are non-DB tests they are executed in parallel, risk to have a race.
Failed canary builds https://github.com/apache/airflow/actions/runs/11461340167/job/31890715886 and https://github.com/apache/airflow/actions/runs/11467168248/job/31909855847
Attempting to fix with a context for log capturing.
FYI @OliverWannenwetsch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pytest caplog after PR #43153 [airflow]
Posted by "OliverWannenwetsch (via GitHub)" <gi...@apache.org>.
OliverWannenwetsch commented on PR #43279:
URL: https://github.com/apache/airflow/pull/43279#issuecomment-2431117278
Thank you @jscheffl for your effort here. I was not aware that caplog has concurrency issues. I will not use it in future PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pytest caplog after PR #43153 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #43279:
URL: https://github.com/apache/airflow/pull/43279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pytest caplog after PR #43153 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #43279:
URL: https://github.com/apache/airflow/pull/43279#issuecomment-2430398349
> Uuups, after some loops, was able to still have it failing locally, need to provide a better fix :-(
Now should be stable, removed dependency of logs in caplog as much as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix Pytest caplog after PR #43153 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #43279:
URL: https://github.com/apache/airflow/pull/43279#issuecomment-2430375577
Uuups, after some loops, was able to still have it failing locally, need to provide a better fix :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org