You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/25 17:21:21 UTC
[GitHub] [airflow] zhongjiajie opened a new pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
zhongjiajie opened a new pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900
* Only DEFAULT_VIEW_PRESETS are acceptable
* Only ORIENTATION_PRESETS are acceptable
* Use webserver.dag_default_view in airflow.cfg as default value
* Remove DAG and DagModel function get_default_view
* Rename _default_value to default_value
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6346
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
* Only DEFAULT_VIEW_PRESETS are acceptable
* Only ORIENTATION_PRESETS are acceptable
* Use webserver.dag_default_view in airflow.cfg as default value
* Remove DAG and DagModel function get_default_view
* Rename _default_value to default_value
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r370935555
##########
File path: airflow/models/dag.py
##########
@@ -296,8 +298,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
Review comment:
So I think is ok to change to `default_view `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374641552
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
**keep in the old name _default_view** for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r363106891
##########
File path: airflow/models/dag.py
##########
@@ -296,8 +298,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
Review comment:
I'm not really sure why we use `self._default_view` as property name before? Prevent cover the Flask `default_view` variable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r373834496
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
This makes this version 2 of the schema sadly, so we now need to think about how we handle versions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r373834415
##########
File path: airflow/models/dag.py
##########
@@ -300,8 +302,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
- self.orientation = orientation
+ if default_view in DEFAULT_VIEW_PRESETS:
+ self.default_view = default_view
+ else:
+ raise AirflowException(f'Invalid values of dag.default_view: only support '
+ f'{DEFAULT_VIEW_PRESETS}, but get {default_view}')
Review comment:
Do f-strings work in py3.6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-568917571
Invalid `default_view` will cause Airflow webserver error.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] milton0825 commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
milton0825 commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r369755076
##########
File path: airflow/models/dag.py
##########
@@ -296,8 +298,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
Review comment:
no idea either...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-587346396
@ashb @kaxil CI green, I think is ready to review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374021290
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
Do you mean we should update user's exists schema in databases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571072094
CI green, PTAL @potiuk @mik-laj @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374020451
##########
File path: airflow/models/dag.py
##########
@@ -300,8 +302,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
- self.orientation = orientation
+ if default_view in DEFAULT_VIEW_PRESETS:
+ self.default_view = default_view
+ else:
+ raise AirflowException(f'Invalid values of dag.default_view: only support '
+ f'{DEFAULT_VIEW_PRESETS}, but get {default_view}')
Review comment:
Yeah, I think it work in py3.6 https://www.python.org/dev/peps/pep-0498/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r373836175
##########
File path: airflow/serialization/serialized_objects.py
##########
@@ -467,7 +467,7 @@ def __get_constructor_defaults(): # pylint: disable=no-method-argument
param_to_attr = {
'concurrency': '_concurrency',
'description': '_description',
- 'default_view': '_default_view',
+ 'default_view': 'default_view',
'access_control': '_access_control',
Review comment:
I don't think this is needed anymore and the whole line can be removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6900: [AIRFLOW-6346] Enhance
dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-581119268
@ashb WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-589942506
Thanks for merging @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #6900: [AIRFLOW-6346] Enhance
dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r378914969
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
> **keep in the old name _default_view** for now
Ok, I get it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-578409576
According to https://github.com/apache/airflow/pull/6900#discussion_r363106891 no one know the reason, @potiuk @kaxil I think is ok to change property name from `_default_view` to `default_view`, and I test it locally and it work, So pls task a look a this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374637765
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
I remark here, so we have two ways:
* change schema name to `default_view` and make compatible to existing dags
* keep in the old name `_default_view`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374641552
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
_keep in the old name _default_view_ for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/ab80880fedb7843baa5b6e0f11d3fd99ded4b5cc?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
+ Coverage 85.28% 85.32% +0.03%
==========================================
Files 707 707
Lines 39255 39356 +101
==========================================
+ Hits 33478 33579 +101
Misses 5777 5777
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `90.03% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.96% <100%> (+0.1%)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_list\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfbGlzdF9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_gcs.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZ2NzLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_acl\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3NfYWNsX29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcs\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djc19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/sensors/gcs\_sensor.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZ2NzX3NlbnNvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_dataproc\_hook.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9kYXRhcHJvY19ob29rLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/bin/cli.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9iaW4vY2xpLnB5) | `94.73% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcs\_operator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3Nfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| ... and [5 more](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [ab80880...f6a05e4](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r369496408
##########
File path: airflow/models/dag.py
##########
@@ -296,8 +298,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
Review comment:
I have no idea tbh, @vardancse @milton0825 - Do you guys have any idea about it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6900: [AIRFLOW-6346]
Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-571036436
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=h1) Report
> Merging [#6900](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/f4c7d17902c87bff50bbd8c94028a539e4e1c3a3?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6900 +/- ##
==========================================
- Coverage 85.01% 85.01% -0.01%
==========================================
Files 680 680
Lines 38748 38746 -2
==========================================
- Hits 32942 32939 -3
- Misses 5806 5807 +1
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/serialization/serialized\_objects.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZXJpYWxpemF0aW9uL3NlcmlhbGl6ZWRfb2JqZWN0cy5weQ==) | `91.12% <ø> (ø)` | :arrow_up: |
| [airflow/models/dag.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFnLnB5) | `90.73% <100%> (+0.11%)` | :arrow_up: |
| [airflow/utils/log/file\_processor\_handler.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9sb2cvZmlsZV9wcm9jZXNzb3JfaGFuZGxlci5weQ==) | `85.33% <0%> (-2.67%)` | :arrow_down: |
| [airflow/models/baseoperator.py](https://codecov.io/gh/apache/airflow/pull/6900/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvYmFzZW9wZXJhdG9yLnB5) | `96.25% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=footer). Last update [f4c7d17...2f857fd](https://codecov.io/gh/apache/airflow/pull/6900?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #6900: [AIRFLOW-6346] Enhance
dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-573388572
I am not as good/knowledgable in the UI/Flask part. MAybe someone else can review this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6900: [AIRFLOW-6346] Enhance
dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#issuecomment-589643428
Thanks @zhongjiajie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] zhongjiajie commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r363106891
##########
File path: airflow/models/dag.py
##########
@@ -296,8 +298,16 @@ def __init__(
self.max_active_runs = max_active_runs
self.dagrun_timeout = dagrun_timeout
self.sla_miss_callback = sla_miss_callback
- self._default_view = default_view
Review comment:
I change name from `_default_view` -> `default_view`
I'm not really sure why we use `self._default_view` as property name before? Prevent cover the Flask `default_view` variable ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #6900:
[AIRFLOW-6346] Enhance dag default_view and orientation
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #6900: [AIRFLOW-6346] Enhance dag default_view and orientation
URL: https://github.com/apache/airflow/pull/6900#discussion_r374025787
##########
File path: airflow/serialization/schema.json
##########
@@ -93,7 +93,7 @@
"end_date": { "$ref": "#/definitions/datetime" },
"dagrun_timeout": { "$ref": "#/definitions/timedelta" },
"doc_md": { "type" : "string"},
- "_default_view": { "type" : "string"},
+ "default_view": { "type" : "string"},
Review comment:
Yes, it would break the existing Dags in D. To get past it wr can revert the renaming of _default_view
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services