You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/07/02 20:42:56 UTC
[kudu-CR] KUDU-2671 fix handling hash dimensions in ADD RANGE PARTITION
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18695
Change subject: KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
......................................................................
KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
This patch fixes a bug in handling hash dimensions when storing the
information on HashSchema for a newly added range in the system catalog.
I modfied one already existing test scenario in MasterTest to spot
regressions, verifying that before the fix the updated scenario
would fail as expected.
This is a follow-up to 6909ee4f800da192b72e59680916e5004527b6db.
Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
2 files changed, 39 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/18695/1
--
To view, visit http://gerrit.cloudera.org:8080/18695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] KUDU-2671 fix handling hash dimensions in ADD RANGE PARTITION
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18695 )
Change subject: KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 20:49:18 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2671 fix handling hash dimensions in ADD RANGE PARTITION
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix handling hash dimensions in ADD RANGE PARTITION
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18695 )
Change subject: KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
......................................................................
KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
This patch fixes a bug in handling hash dimensions when storing the
information on HashSchema for a newly added range in the system catalog.
I modfied one already existing test scenario in MasterTest to spot
regressions, verifying that before the fix the updated scenario
would fail as expected.
This is a follow-up to 6909ee4f800da192b72e59680916e5004527b6db.
Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Reviewed-on: http://gerrit.cloudera.org:8080/18695
Reviewed-by: Attila Bukor <ab...@apache.org>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master-test.cc
2 files changed, 39 insertions(+), 6 deletions(-)
Approvals:
Attila Bukor: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
[kudu-CR] KUDU-2671 fix handling hash dimensions in ADD RANGE PARTITION
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18695 )
Change subject: KUDU-2671 fix handling hash dimensions in ADD_RANGE_PARTITION
......................................................................
Patch Set 1: Verified+1
unrelated test failures:
* log-rolling-itest (ASAN)
* TxnOpDispatcherITest.TxnWriteWhileReplicaDeleted (ASAN)
* txn_commit-itest (TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/18695
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If1fed52f9abd02a8aa2bc85f2692252d16965621
Gerrit-Change-Number: 18695
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 Jul 2022 21:18:41 +0000
Gerrit-HasComments: No