You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by as...@apache.org on 2019/07/19 19:30:30 UTC

[qpid-proton] 04/04: PROTON-2063: [go] Sender auto settlement should only happen after receiver settlement

This is an automated email from the ASF dual-hosted git repository.

astitcher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/qpid-proton.git

commit 97b62d2b7ce22c84e7d8db1ace8aa0355ea5fbe7
Author: Andrew Stitcher <as...@apache.org>
AuthorDate: Fri Jul 19 14:46:00 2019 -0400

    PROTON-2063: [go] Sender auto settlement should only happen after receiver settlement
---
 go/src/qpid.apache.org/proton/handlers.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/go/src/qpid.apache.org/proton/handlers.go b/go/src/qpid.apache.org/proton/handlers.go
index bbb5014..8549919 100644
--- a/go/src/qpid.apache.org/proton/handlers.go
+++ b/go/src/qpid.apache.org/proton/handlers.go
@@ -389,9 +389,9 @@ func (d *MessagingAdapter) outgoing(e Event) {
 		if delivery.Settled() {
 			// The delivery was settled remotely, inform the local end.
 			d.mhandler.HandleMessagingEvent(MSettled, e)
-		}
-		if d.AutoSettle {
-			delivery.Settle() // Local settle, don't mhandler MSettled till the remote end settles.
+			if d.AutoSettle {
+				delivery.Settle()
+			}
 		}
 	}
 	return


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org