[GitHub] [airflow] soliverr commented on a change in pull request #16848: Cosmetic fixes to make Spark provider work

[GitBox <gi...@apache.org>]

soliverr commented on a change in pull request #16848:
URL: https://github.com/apache/airflow/pull/16848#discussion_r665938100



##########
File path: airflow/providers/apache/spark/hooks/spark_jdbc.py
##########
@@ -196,6 +196,7 @@ def _resolve_jdbc_connection(self) -> Dict[str, Any]:
             conn_data['password'] = conn.password
             extra = conn.extra_dejson
             conn_data['conn_prefix'] = extra.get('conn_prefix', '')
+            conn_data['conn_suffix'] = extra.get('conn_suffix', '')

Review comment:
       It's just a proposal. For example, I have Spark JDBC connection for MS SQL Server, in which I have to specify the database' name to connect to:
   
   `jdbc:sqlserver://hostname:port;databaseName=db;`
   
   The only way to do this is to put the entire URL-string in the `Host` field of the 'Edit connection' form.
   
   So, it seems useful to add a suffix to deal with cases like this.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org