You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2010/06/20 01:08:24 UTC

DO NOT REPLY [Bug 49473] New: [PATCH] missing extension-point behaviour

https://issues.apache.org/bugzilla/show_bug.cgi?id=49473

           Summary: [PATCH] missing extension-point behaviour
           Product: Ant
           Version: 1.8.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Core
        AssignedTo: notifications@ant.apache.org
        ReportedBy: danny@codeaholics.org


Created an attachment (id=25621)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25621)
Patch for requested enhancement

Hi guys,

I'm loving the new 1.8 extension point functionality.

I'm working on a project which has multiple deployable components ("services")
and has separate build and deploy scripts. I'd like to use extension points to
be able to write a single "descriptor" for any given service in order to
centralise the definitions of services which are currently sprinkled liberally
throughout the build and deploy scripts.

The problem I have is that some of the targets in the descriptor are extensions
of extension points in the build script (and are only used during build) and
some are extensions of extension points in the deploy script (and are only used
during deployment). Of course, this doesn't work because ProjectHelper2 tries
to verify the existence of an extension point during project file parsing and
which extension points are present is a function of whether the importing
script is the build script or the deploy script.

I've made some changes to add an "extension-point-missing" attribute which
takes values:
- "error" - the current behaviour (and default if the attribute is missing)
- "warn" - log a warning and ignore (see next)
- "ignore" - don't stop or warn, and don't add the extension target as a
dependency of the (non-existent) extension point

I've attached a patch for consideration for Ant 1.8.2

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49473] [PATCH] missing extension-point behaviour

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49473

Danny Yates <da...@codeaholics.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25621|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #25621|0                           |1
           is patch|                            |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49473] [PATCH] missing extension-point behaviour

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49473

Stefan Bodewig <bo...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED
   Target Milestone|---                         |1.8.2

--- Comment #2 from Stefan Bodewig <bo...@apache.org> 2010-06-23 08:16:12 EDT ---
patches are in with some modifications (naming, in particular) with svn
revision 957170

Many thanks!

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

DO NOT REPLY [Bug 49473] [PATCH] missing extension-point behaviour

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49473

--- Comment #1 from Danny Yates <da...@codeaholics.org> 2010-06-19 19:24:25 EDT ---
Created an attachment (id=25622)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25622)
Patch for documentation

Added patch for documentation

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.