You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/06/02 00:31:21 UTC
Re: Review Request 34140: AppC image store


> On May 26, 2015, 11:28 a.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/appc/store.cpp, line 79
> > <https://reviews.apache.org/r/34140/diff/1/?file=957277#file957277line79>
> >
> >     Check exists first?

os::mkdir() ignores EEXIST so won't return an error if it already exists.


> On May 26, 2015, 11:28 a.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/appc/store.hpp, line 55
> > <https://reviews.apache.org/r/34140/diff/1/?file=957276#file957276line55>
> >
> >     Is this suppose to be a generic Store? It returns a list of AppcImage but this is a generic namespace under slave.
> >     Should we have a base class like ContainerImage?

No, it's specific to appc images at the moment. Could be refactored if/when necessary.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140/#review83840
-----------------------------------------------------------


On May 26, 2015, 11:25 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34140/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 11:25 a.m.)
> 
> 
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Images are fetched into the store (after discovery). Stored images are
> currently kept indefinitely.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693 
>   src/slave/containerizer/provisioners/appc/store.hpp PRE-CREATION 
>   src/slave/containerizer/provisioners/appc/store.cpp PRE-CREATION 
>   src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032 
>   src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932 
> 
> Diff: https://reviews.apache.org/r/34140/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Downes
> 
>