You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/05/03 07:14:10 UTC
[GitHub] [lucene] iverase opened a new pull request #123: LUCENE-9047: Write checksum as Big endian in NRT replicator
iverase opened a new pull request #123:
URL: https://github.com/apache/lucene/pull/123
Left over from #107, we should read / write checksums using big endian in the NRT replicator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a bug in the security policy, so no NRT Test is running at all. So you did not see the test failure.
If you fix it, make sure to run the replicator tests with `-Dtests.nightly=true`, so it runs all tests (takes a few minutes)
I will backport the test fixes also to 8.x later. It's great that we fixed it yesterday :-) The NRT tests were not running since now YEARS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831351741
the suppressAccessChecks permission got lost in master, so the NRT tests were not able to crush the test server with SIGSEGV. It's now working in both master and 8.x. I ran the tests and all worked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
iverase commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831237759
Thanks @uschindler, yikes that explain it all :)
This fix seems to work, I run the test with the nightly flag and it seems happy:
```
./gradlew :lucene:replicator:test -Dtests.nightly=true
> Task :randomizationInfo
Running tests with randomization seed: tests.seed=3735F7B6C10CE977
> Task :lucene:replicator:test
:lucene:replicator:test (SUCCESS): 44 test(s), 1 skipped
The slowest tests (exceeding 500 ms) during this run:
190.02s TestStressNRTReplication.test (:lucene:replicator)
7.52s TestIndexAndTaxonomyReplicationClient.testConsistencyOnExceptions (:lucene:replicator)
6.52s TestNRTReplication.testFullClusterCrash (:lucene:replicator)
5.44s TestIndexReplicationClient.testConsistencyOnExceptions (:lucene:replicator)
3.49s TestNRTReplication.testCrashPrimary3 (:lucene:replicator)
3.36s TestNRTReplication.testCrashReplica (:lucene:replicator)
3.27s TestNRTReplication.testCrashPrimary2 (:lucene:replicator)
2.65s TestNRTReplication.testReplicaCrashWithCommit (:lucene:replicator)
2.52s TestNRTReplication.testCrashPrimary1 (:lucene:replicator)
2.52s TestNRTReplication.testIndexingWhileReplicaIsDown (:lucene:replicator)
The slowest suites (exceeding 1s) during this run:
190.06s TestStressNRTReplication (:lucene:replicator)
32.55s TestNRTReplication (:lucene:replicator)
8.33s TestIndexAndTaxonomyReplicationClient (:lucene:replicator)
6.28s TestIndexReplicationClient (:lucene:replicator)
BUILD SUCCESSFUL in 3m 27s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831394750
Awesome, thank you @uschindler!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831256482
What did you change, or was the test failures on Jenkins only because of the first merge on the directory API and this one fixed it?
This explains why you opened THIS pull request. Sorry for the noise.
Uwe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] iverase merged pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #123:
URL: https://github.com/apache/lucene/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler edited a comment on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler edited a comment on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a bug in the security policy, so no NRT Test wasn't running at all. So you did not see the test failure.
If you fix it, make sure to run the replicator tests with `-Dtests.nightly=true`, so it runs all tests (takes a few minutes)
I will backport the test fixes also to 8.x later. It's great that we fixed it yesterday :-) The NRT tests were not running since now YEARS!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mikemccand commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831263447
> The NRT tests were not running since now YEARS!
OH NO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831257258
It will be funny, when Solr picks the new snapshot builds!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #123: LUCENE-9047: Write checksum as big endian in NRT replicator
Posted by GitBox <gi...@apache.org>.
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831347167
I backported the fixes. But I can tell you: It was only a master problm, 8.x was fine. I still backported Dawid's fixes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org