[GitHub] [cassandra] dcapwell commented on a diff in pull request #2310: CASSANDRA-18504: Added support for type VECTOR

["dcapwell (via GitHub)" <gi...@apache.org>]

dcapwell commented on code in PR #2310:
URL: https://github.com/apache/cassandra/pull/2310#discussion_r1215028079


##########
src/java/org/apache/cassandra/db/marshal/ListType.java:
##########
@@ -127,7 +127,7 @@ public ListSerializer<T> getSerializer()
     public AbstractType<?> freeze()
     {
         if (isMultiCell)
-            return getInstance(this.elements, false);
+            return getInstance(this.elements.freeze(), false);

Review Comment:
   need to think about this more... if the parent is frozen then it really doesn't matter if the children are or not...  but it does for equality and for the type tests... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org